Add fish shell format for export-credentials #9996
Open
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds Fish shell support to the aws configure export-credentials command, allowing Fish shell users to export AWS credentials in a format compatible with their shell.
Changes:
- Added a new
FishShellFormatterclass that outputs credentials using Fish shell'sset -gxsyntax - Updated the
SUPPORTED_FORMATSdictionary to include the new Fish formatter - Added comprehensive unit tests for the Fish shell formatter covering both static and temporary credentials
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| awscli/customizations/configure/exportcreds.py | Implements FishShellFormatter class and registers it in SUPPORTED_FORMATS |
| tests/unit/customizations/configure/test_exportcreds.py | Adds test cases for FishShellFormatter with expected output formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minjcho
force-pushed
the
feature/fish-shell-export-credentials
branch
from
622af44 to
1c54577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9670
Description of changes:
This change lets Fish users apply exported credentials directly without extra conversion.
Usage:
Example output:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.